orcs-oss/orcs-code
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Trim another narrow batch of dialog cleanup noise (#317)

Browse Source 
This follow-up pass continues the phased unused-code cleanup from issue #314 with four dialog components that shared the same low-risk pattern: avoidable unused imports, dormant Props aliases, and untyped callback plumbing that only existed as compiler noise. The changes keep behavior intact while reducing the next layer of cleanup friction.

Constraint: Keep the second pass narrowly scoped and homogeneous so it stays easy to review beside PR #316
Rejected: Fold in EffortCallout and wider component cleanup at the same time | larger surface area and less uniform risk profile
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Continue batching future passes by shared cleanup pattern; leave broader refactors and compatibility placeholders for separate PRs
Tested: bun run build; bun run smoke; targeted noUnused grep for touched files via bun x tsc --noEmit --noUnusedLocals --noUnusedParameters --pretty false
Not-tested: full repo typecheck (broader baseline noise remains outside this pass)

Co-authored-by: anandh8x <test@example.com>
This commit is contained in:
Anandan
2026-04-04 11:41:08 +05:30
committed by GitHub
parent c52245fc0a
commit bffd43056f
4 changed files with 21 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/components/BypassPermissionsModeDialog.tsx
View File

@@ -1,5 +1,5 @@
import { c as _c } from "react-compiler-runtime";
import React, { useCallback } from 'react';
import React from 'react';
import { logEvent } from 'src/services/analytics/index.js';
import { Box, Link, Newline, Text } from '../ink.js';
import { gracefulShutdownSync } from '../utils/gracefulShutdown.js';
@@ -9,12 +9,12 @@ import { Dialog } from './design-system/Dialog.js';
type Props = {
onAccept(): void;
};
export function BypassPermissionsModeDialog(t0) {
export function BypassPermissionsModeDialog(t0: Props) {
const $ = _c(7);
const {
onAccept
} = t0;
let t1;
let t1: [];
if ($[0] === Symbol.for("react.memo_cache_sentinel")) {
t1 = [];
$[0] = t1;
@@ -24,7 +24,7 @@ export function BypassPermissionsModeDialog(t0) {
React.useEffect(_temp, t1);
let t2;
if ($[1] !== onAccept) {
t2 = function onChange(value) {
t2 = function onChange(value: 'accept' | 'decline') {
bb3: switch (value) {
case "accept":
{
@@ -70,7 +70,7 @@ export function BypassPermissionsModeDialog(t0) {
}
let t5;
if ($[5] !== onChange) {
t5 = <Dialog title="WARNING: Claude Code running in Bypass Permissions mode" color="error" onCancel={handleEscape}>{t3}<Select options={t4} onChange={value_0 => onChange(value_0 as 'accept' | 'decline')} /></Dialog>;
t5 = <Dialog title="WARNING: Claude Code running in Bypass Permissions mode" color="error" onCancel={handleEscape}>{t3}<Select options={t4} onChange={(value_0: string) => onChange(value_0 as 'accept' | 'decline')} /></Dialog>;
$[5] = onChange;
$[6] = t5;
} else {