Trim another narrow batch of dialog cleanup noise (#317)

This follow-up pass continues the phased unused-code cleanup from issue #314 with four dialog components that shared the same low-risk pattern: avoidable unused imports, dormant Props aliases, and untyped callback plumbing that only existed as compiler noise. The changes keep behavior intact while reducing the next layer of cleanup friction.

Constraint: Keep the second pass narrowly scoped and homogeneous so it stays easy to review beside PR #316
Rejected: Fold in EffortCallout and wider component cleanup at the same time | larger surface area and less uniform risk profile
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Continue batching future passes by shared cleanup pattern; leave broader refactors and compatibility placeholders for separate PRs
Tested: bun run build; bun run smoke; targeted noUnused grep for touched files via bun x tsc --noEmit --noUnusedLocals --noUnusedParameters --pretty false
Not-tested: full repo typecheck (broader baseline noise remains outside this pass)

Co-authored-by: anandh8x <test@example.com>
This commit is contained in:
Anandan
2026-04-04 11:41:08 +05:30
committed by GitHub
parent c52245fc0a
commit bffd43056f
4 changed files with 21 additions and 22 deletions

View File

@@ -14,14 +14,14 @@ type Props = {
// Startup gate: decline exits the process, so relabel accordingly.
declineExits?: boolean;
};
export function AutoModeOptInDialog(t0) {
export function AutoModeOptInDialog(t0: Props) {
const $ = _c(18);
const {
onAccept,
onDecline,
declineExits
} = t0;
let t1;
let t1: [];
if ($[0] === Symbol.for("react.memo_cache_sentinel")) {
t1 = [];
$[0] = t1;
@@ -31,7 +31,7 @@ export function AutoModeOptInDialog(t0) {
React.useEffect(_temp, t1);
let t2;
if ($[1] !== onAccept || $[2] !== onDecline) {
t2 = function onChange(value) {
t2 = function onChange(value: 'accept' | 'accept-default' | 'decline') {
bb3: switch (value) {
case "accept":
{
@@ -109,7 +109,7 @@ export function AutoModeOptInDialog(t0) {
}
let t8;
if ($[9] !== onChange) {
t8 = value_0 => onChange(value_0 as 'accept' | 'accept-default' | 'decline');
t8 = (value_0: string) => onChange(value_0 as 'accept' | 'accept-default' | 'decline');
$[9] = onChange;
$[10] = t8;
} else {

View File

@@ -1,5 +1,5 @@
import { c as _c } from "react-compiler-runtime";
import React, { useCallback } from 'react';
import React from 'react';
import { logEvent } from 'src/services/analytics/index.js';
import { Box, Link, Newline, Text } from '../ink.js';
import { gracefulShutdownSync } from '../utils/gracefulShutdown.js';
@@ -9,12 +9,12 @@ import { Dialog } from './design-system/Dialog.js';
type Props = {
onAccept(): void;
};
export function BypassPermissionsModeDialog(t0) {
export function BypassPermissionsModeDialog(t0: Props) {
const $ = _c(7);
const {
onAccept
} = t0;
let t1;
let t1: [];
if ($[0] === Symbol.for("react.memo_cache_sentinel")) {
t1 = [];
$[0] = t1;
@@ -24,7 +24,7 @@ export function BypassPermissionsModeDialog(t0) {
React.useEffect(_temp, t1);
let t2;
if ($[1] !== onAccept) {
t2 = function onChange(value) {
t2 = function onChange(value: 'accept' | 'decline') {
bb3: switch (value) {
case "accept":
{
@@ -70,7 +70,7 @@ export function BypassPermissionsModeDialog(t0) {
}
let t5;
if ($[5] !== onChange) {
t5 = <Dialog title="WARNING: Claude Code running in Bypass Permissions mode" color="error" onCancel={handleEscape}>{t3}<Select options={t4} onChange={value_0 => onChange(value_0 as 'accept' | 'decline')} /></Dialog>;
t5 = <Dialog title="WARNING: Claude Code running in Bypass Permissions mode" color="error" onCancel={handleEscape}>{t3}<Select options={t4} onChange={(value_0: string) => onChange(value_0 as 'accept' | 'decline')} /></Dialog>;
$[5] = onChange;
$[6] = t5;
} else {

View File

@@ -1,5 +1,5 @@
import { c as _c } from "react-compiler-runtime";
import React, { useCallback } from 'react';
import React from 'react';
import { logEvent } from 'src/services/analytics/index.js';
import { Box, Link, Text } from '../ink.js';
import type { ExternalClaudeMdInclude } from '../utils/claudemd.js';
@@ -11,14 +11,14 @@ type Props = {
isStandaloneDialog?: boolean;
externalIncludes?: ExternalClaudeMdInclude[];
};
export function ClaudeMdExternalIncludesDialog(t0) {
export function ClaudeMdExternalIncludesDialog(t0: Props) {
const $ = _c(18);
const {
onDone,
isStandaloneDialog,
externalIncludes
} = t0;
let t1;
let t1: [];
if ($[0] === Symbol.for("react.memo_cache_sentinel")) {
t1 = [];
$[0] = t1;
@@ -28,7 +28,7 @@ export function ClaudeMdExternalIncludesDialog(t0) {
React.useEffect(_temp, t1);
let t2;
if ($[1] !== onDone) {
t2 = value => {
t2 = (value: 'yes' | 'no') => {
if (value === "no") {
logEvent("tengu_claude_md_external_includes_dialog_declined", {});
saveCurrentProjectConfig(_temp2);
@@ -94,7 +94,7 @@ export function ClaudeMdExternalIncludesDialog(t0) {
}
let t10;
if ($[10] !== handleSelection) {
t10 = <Select options={t9} onChange={value_0 => handleSelection(value_0 as 'yes' | 'no')} />;
t10 = <Select options={t9} onChange={(value_0: string) => handleSelection(value_0 as 'yes' | 'no')} />;
$[10] = handleSelection;
$[11] = t10;
} else {
@@ -114,17 +114,17 @@ export function ClaudeMdExternalIncludesDialog(t0) {
}
return t11;
}
function _temp4(include, i) {
function _temp4(include: ExternalClaudeMdInclude, i: number) {
return <Text key={i} dimColor={true}>{" "}{include.path}</Text>;
}
function _temp3(current_0) {
function _temp3(current_0: any) {
return {
...current_0,
hasClaudeMdExternalIncludesApproved: true,
hasClaudeMdExternalIncludesWarningShown: true
};
}
function _temp2(current) {
function _temp2(current: any) {
return {
...current,
hasClaudeMdExternalIncludesApproved: false,

View File

@@ -1,5 +1,4 @@
import { c as _c } from "react-compiler-runtime";
import React, { useCallback } from 'react';
import type { ChannelEntry } from '../bootstrap/state.js';
import { Box, Text } from '../ink.js';
import { gracefulShutdownSync } from '../utils/gracefulShutdown.js';
@@ -9,7 +8,7 @@ type Props = {
channels: ChannelEntry[];
onAccept(): void;
};
export function DevChannelsDialog(t0) {
export function DevChannelsDialog(t0: Props) {
const $ = _c(14);
const {
channels,
@@ -17,7 +16,7 @@ export function DevChannelsDialog(t0) {
} = t0;
let t1;
if ($[0] !== onAccept) {
t1 = function onChange(value) {
t1 = function onChange(value: 'accept' | 'exit') {
bb2: switch (value) {
case "accept":
{
@@ -79,7 +78,7 @@ export function DevChannelsDialog(t0) {
}
let t7;
if ($[9] !== onChange) {
t7 = <Select options={t6} onChange={value_0 => onChange(value_0 as 'accept' | 'exit')} />;
t7 = <Select options={t6} onChange={(value_0: string) => onChange(value_0 as 'accept' | 'exit')} />;
$[9] = onChange;
$[10] = t7;
} else {
@@ -96,7 +95,7 @@ export function DevChannelsDialog(t0) {
}
return t8;
}
function _temp2(c) {
function _temp2(c: ChannelEntry) {
return c.kind === "plugin" ? `plugin:${c.name}@${c.marketplace}` : `server:${c.name}`;
}
function _temp() {