bd73bcc9d7
Closes #856. MCP servers that expose resources (e.g. RepoPrompt) failed to load their tools in the open build with: Error fetching tools/commands/resources: fetchMcpSkillsForClient is not a function Root cause: scripts/build.ts set MCP_SKILLS: true, which made feature('MCP_SKILLS') evaluate to true at build time. The guards around the dynamic skill discovery path therefore stayed live. The underlying source file src/skills/mcpSkills.ts is not mirrored into the open tree, so the bundler fell back to its generic missing-module stub — which only exports `default` for require()-style imports, not the named `fetchMcpSkillsForClient` binding. At runtime the require returned an object without that property, and calling it threw. `openclaude mcp doctor` reported RepoPrompt as healthy because doctor does not exercise the skills-fetch path. Fix: flip MCP_SKILLS to false and move it into the "Disabled: missing source" group. With the flag off, every `if (feature('MCP_SKILLS'))` guard becomes a no-op at build time, the require() branch is dead code, and MCP servers with resources load normally via the existing `Promise.resolve([])` fallbacks already present at each call site. Also adds scripts/feature-flags-source-guard.test.ts to fail fast if MCP_SKILLS (or any future flag in the same category) is re-enabled without the corresponding source file being mirrored first. Verification: - Test fails on main, passes with this fix - `bun run build` produces a bundle with no `missing-module-stub:../../skills/mcpSkills.js` reference - Full `bun test` — 1222 pass / 12 fail (same pre-existing 12 as main; new test adds the +1 pass)
48 lines
1.9 KiB
TypeScript
48 lines
1.9 KiB
TypeScript
import { existsSync, readFileSync } from 'fs'
|
|
import { join } from 'path'
|
|
import { expect, test } from 'bun:test'
|
|
|
|
// Regression guard for #856. Several build feature flags require source files
|
|
// that are not mirrored into the open build. When such a flag is set to `true`
|
|
// without the source present, the bundler falls back to a missing-module stub
|
|
// that only exports `default`, which causes runtime errors like
|
|
// `fetchMcpSkillsForClient is not a function` when downstream code reaches
|
|
// through the `require()` to a named export.
|
|
//
|
|
// This test fails fast at test-time if someone re-enables one of these flags
|
|
// without first mirroring the corresponding source file.
|
|
|
|
const BUILD_SCRIPT = join(import.meta.dir, 'build.ts')
|
|
const REPO_ROOT = join(import.meta.dir, '..')
|
|
|
|
type FlagGuard = {
|
|
flag: string
|
|
source: string // path relative to repo root
|
|
}
|
|
|
|
const FLAG_REQUIRES_SOURCE: FlagGuard[] = [
|
|
{ flag: 'MCP_SKILLS', source: 'src/skills/mcpSkills.ts' },
|
|
]
|
|
|
|
test('build feature flags are not enabled without their source files', () => {
|
|
const buildScript = readFileSync(BUILD_SCRIPT, 'utf-8')
|
|
|
|
for (const { flag, source } of FLAG_REQUIRES_SOURCE) {
|
|
const enabledRe = new RegExp(`^\\s*${flag}\\s*:\\s*true\\b`, 'm')
|
|
const isEnabled = enabledRe.test(buildScript)
|
|
const sourceExists = existsSync(join(REPO_ROOT, source))
|
|
|
|
if (isEnabled && !sourceExists) {
|
|
throw new Error(
|
|
`Feature flag ${flag} is enabled in scripts/build.ts, but its required source file "${source}" does not exist. ` +
|
|
`Enabling this flag without the source will cause runtime errors (missing named exports from the missing-module stub). ` +
|
|
`Either mirror the source file or set ${flag}: false.`,
|
|
)
|
|
}
|
|
|
|
// When the source IS present, the flag can be either true or false; either
|
|
// is fine. We only care about the "enabled but missing" combination.
|
|
expect(true).toBe(true)
|
|
}
|
|
})
|