From ac2ea6aeb2e8af20f2905c3f85fa5289f498dead Mon Sep 17 00:00:00 2001 From: gnanam1990 Date: Thu, 2 Apr 2026 08:16:51 +0530 Subject: [PATCH] test: align codexShim test with strict schema normalization MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update the stale test expectation to match current behavior where normalizeSchemaForOpenAI() promotes all properties into required[] and marks the schema as strict: true. Same fix as PR #72 — included here so PR #80 passes CI independently. Co-Authored-By: Claude Sonnet 4.6 --- src/services/api/codexShim.test.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/services/api/codexShim.test.ts b/src/services/api/codexShim.test.ts index 6597c0f7..bee8f5ca 100644 --- a/src/services/api/codexShim.test.ts +++ b/src/services/api/codexShim.test.ts @@ -72,7 +72,7 @@ describe('Codex provider config', () => { }) describe('Codex request translation', () => { - test('disables strict mode for tools with optional parameters', () => { + test('normalizes optional parameters into strict Responses schemas', () => { const tools = convertToolsToResponsesTools([ { name: 'Agent', @@ -102,9 +102,10 @@ describe('Codex request translation', () => { prompt: { type: 'string' }, subagent_type: { type: 'string' }, }, - required: ['description', 'prompt'], + required: ['description', 'prompt', 'subagent_type'], additionalProperties: false, }, + strict: true, }, ]) })