fix: harden provider recommendation safety

src/utils/providerProfile.test.ts

@@ -0,0 +1,92 @@
+import assert from 'node:assert/strict'
+import test from 'node:test'
+
+import {
+  buildLaunchEnv,
+  buildOllamaProfileEnv,
+  selectAutoProfile,
+  type ProfileFile,
+} from './providerProfile.ts'
+
+function profile(profile: ProfileFile['profile'], env: ProfileFile['env']): ProfileFile {
+  return {
+    profile,
+    env,
+    createdAt: '2026-04-01T00:00:00.000Z',
+  }
+}
+
+test('matching persisted ollama env is reused for ollama launch', async () => {
+  const env = await buildLaunchEnv({
+    profile: 'ollama',
+    persisted: profile('ollama', {
+      OPENAI_BASE_URL: 'http://127.0.0.1:11435/v1',
+      OPENAI_MODEL: 'mistral:7b-instruct',
+    }),
+    goal: 'balanced',
+    processEnv: {},
+    getOllamaChatBaseUrl: () => 'http://localhost:11434/v1',
+    resolveOllamaDefaultModel: async () => 'llama3.1:8b',
+  })
+
+  assert.equal(env.OPENAI_BASE_URL, 'http://127.0.0.1:11435/v1')
+  assert.equal(env.OPENAI_MODEL, 'mistral:7b-instruct')
+})
+
+test('ollama launch ignores mismatched persisted openai env and shell model fallback', async () => {
+  const env = await buildLaunchEnv({
+    profile: 'ollama',
+    persisted: profile('openai', {
+      OPENAI_BASE_URL: 'https://api.openai.com/v1',
+      OPENAI_MODEL: 'gpt-4o',
+      OPENAI_API_KEY: 'sk-persisted',
+    }),
+    goal: 'coding',
+    processEnv: {
+      OPENAI_BASE_URL: 'https://api.deepseek.com/v1',
+      OPENAI_MODEL: 'gpt-4o-mini',
+    },
+    getOllamaChatBaseUrl: () => 'http://localhost:11434/v1',
+    resolveOllamaDefaultModel: async () => 'qwen2.5-coder:7b',
+  })
+
+  assert.equal(env.OPENAI_BASE_URL, 'http://localhost:11434/v1')
+  assert.equal(env.OPENAI_MODEL, 'qwen2.5-coder:7b')
+})
+
+test('openai launch ignores mismatched persisted ollama env', async () => {
+  const env = await buildLaunchEnv({
+    profile: 'openai',
+    persisted: profile('ollama', {
+      OPENAI_BASE_URL: 'http://localhost:11434/v1',
+      OPENAI_MODEL: 'llama3.1:8b',
+    }),
+    goal: 'latency',
+    processEnv: {
+      OPENAI_API_KEY: 'sk-live',
+    },
+    getOllamaChatBaseUrl: () => 'http://localhost:11434/v1',
+    resolveOllamaDefaultModel: async () => 'llama3.1:8b',
+  })
+
+  assert.equal(env.OPENAI_BASE_URL, 'https://api.openai.com/v1')
+  assert.equal(env.OPENAI_MODEL, 'gpt-4o-mini')
+  assert.equal(env.OPENAI_API_KEY, 'sk-live')
+})
+
+test('ollama profiles never persist openai api keys', () => {
+  const env = buildOllamaProfileEnv('llama3.1:8b', {
+    getOllamaChatBaseUrl: () => 'http://localhost:11434/v1',
+  })
+
+  assert.deepEqual(env, {
+    OPENAI_BASE_URL: 'http://localhost:11434/v1',
+    OPENAI_MODEL: 'llama3.1:8b',
+  })
+  assert.equal('OPENAI_API_KEY' in env, false)
+})
+
+test('auto profile falls back to openai when no viable ollama model exists', () => {
+  assert.equal(selectAutoProfile(null), 'openai')
+  assert.equal(selectAutoProfile('qwen2.5-coder:7b'), 'ollama')
+})