fix: custom OPENAI_BASE_URL always wins over Codex model alias detection (#222)
* feat: add --provider CLI flag for multi-provider support Adds a --provider flag that maps friendly provider names to the environment variables the codebase uses for provider detection. No more manual env-var configuration — users can now simply run: openclaude --provider openai --model gpt-4o openclaude --provider gemini --model gemini-2.0-flash openclaude --provider ollama --model llama3.2 openclaude --provider bedrock openclaude --provider vertex Implementation details: - providerFlag.ts: core logic — maps provider names to env vars, uses ??= so explicit env vars always win over the flag defaults - providerFlag.test.ts: 18 tests covering all 7 providers, error messages, model passthrough, and env-var precedence - cli.tsx: early fast-path (mirrors --bare pattern) — sets env vars before Commander option-building and module constants run - main.tsx: adds --provider to Commander option chain for --help Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: custom OPENAI_BASE_URL always wins over Codex model alias detection When OPENAI_MODEL=gpt-5.4 (or gpt-5.4-mini) and a custom OPENAI_BASE_URL is set (Azure, OpenRouter, etc), the transport was incorrectly forced to codex_responses because gpt-5.4 is in CODEX_ALIAS_MODELS. This caused requests to be sent with Codex auth instead of the user's API key, resulting in 401 Unauthorized errors. Fix: only use codex_responses when the base URL is explicitly the Codex endpoint, OR when no custom base URL is set and the model is a Codex alias. An explicit OPENAI_BASE_URL always takes priority over model-name based Codex detection. Verified locally: gpt-5.4 via OpenRouter now correctly shows Provider=OpenRouter, Endpoint=https://openrouter.ai/api/v1 instead of routing to chatgpt.com/backend-api/codex. Fixes #200, #203 --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -399,6 +399,22 @@ async function main(): Promise<void> {
|
||||
process.env.CLAUDE_CODE_SIMPLE = '1';
|
||||
}
|
||||
|
||||
// --provider: set provider env vars early, before main module loads.
|
||||
// This mirrors the --bare pattern: env vars must be in place before
|
||||
// Commander option building and module-level constants are evaluated.
|
||||
if (args.includes('--provider')) {
|
||||
const { parseProviderFlag, applyProviderFlag } = await import('../utils/providerFlag.js');
|
||||
const provider = parseProviderFlag(args);
|
||||
if (provider) {
|
||||
const result = applyProviderFlag(provider, args);
|
||||
if (result.error) {
|
||||
// biome-ignore lint/suspicious/noConsole:: intentional error output
|
||||
console.error(`Error: ${result.error}`);
|
||||
process.exit(1);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// No special flags detected, load and run the full CLI
|
||||
if (process.env.OPENCLAUDE_ENABLE_EARLY_INPUT === '1') {
|
||||
const {
|
||||
|
||||
@@ -984,7 +984,7 @@ async function run(): Promise<CommanderCommand> {
|
||||
return Number.isFinite(n) ? n : undefined;
|
||||
}).hideHelp()).option('--from-pr [value]', 'Resume a session linked to a PR by PR number/URL, or open interactive picker with optional search term', value => value || true).option('--no-session-persistence', 'Disable session persistence - sessions will not be saved to disk and cannot be resumed (only works with --print)').addOption(new Option('--resume-session-at <message id>', 'When resuming, only messages up to and including the assistant message with <message.id> (use with --resume in print mode)').argParser(String).hideHelp()).addOption(new Option('--rewind-files <user-message-id>', 'Restore files to state at the specified user message and exit (requires --resume)').hideHelp())
|
||||
// @[MODEL LAUNCH]: Update the example model ID in the --model help text.
|
||||
.option('--model <model>', `Model for the current session. Provide an alias for the latest model (e.g. 'sonnet' or 'opus') or a model's full name (e.g. 'claude-sonnet-4-6').`).addOption(new Option('--effort <level>', `Effort level for the current session (low, medium, high, max)`).argParser((rawValue: string) => {
|
||||
.option('--model <model>', `Model for the current session. Provide an alias for the latest model (e.g. 'sonnet' or 'opus') or a model's full name (e.g. 'claude-sonnet-4-6').`).option('--provider <provider>', `AI provider to use (anthropic, openai, gemini, github, bedrock, vertex, ollama). Reads API keys from environment variables.`).addOption(new Option('--effort <level>', `Effort level for the current session (low, medium, high, max)`).argParser((rawValue: string) => {
|
||||
const value = rawValue.toLowerCase();
|
||||
const allowed = ['low', 'medium', 'high', 'max'];
|
||||
if (!allowed.includes(value)) {
|
||||
|
||||
@@ -291,8 +291,13 @@ export function resolveProviderRequest(options?: {
|
||||
process.env.OPENAI_BASE_URL ??
|
||||
process.env.OPENAI_API_BASE ??
|
||||
undefined
|
||||
// Use Codex transport only when:
|
||||
// - the base URL is explicitly the Codex endpoint, OR
|
||||
// - the model is a Codex alias AND no custom base URL has been set
|
||||
// A custom OPENAI_BASE_URL (e.g. Azure, OpenRouter) always wins over
|
||||
// model-name-based Codex detection to prevent auth failures (#200, #203).
|
||||
const transport: ProviderTransport =
|
||||
isCodexAlias(requestedModel) || isCodexBaseUrl(rawBaseUrl)
|
||||
isCodexBaseUrl(rawBaseUrl) || (!rawBaseUrl && isCodexAlias(requestedModel))
|
||||
? 'codex_responses'
|
||||
: 'chat_completions'
|
||||
|
||||
|
||||
139
src/utils/providerFlag.test.ts
Normal file
139
src/utils/providerFlag.test.ts
Normal file
@@ -0,0 +1,139 @@
|
||||
import { describe, expect, test, afterEach } from 'bun:test'
|
||||
import { parseProviderFlag, applyProviderFlag, VALID_PROVIDERS } from './providerFlag.js'
|
||||
|
||||
const originalEnv = { ...process.env }
|
||||
|
||||
afterEach(() => {
|
||||
for (const key of [
|
||||
'CLAUDE_CODE_USE_OPENAI',
|
||||
'CLAUDE_CODE_USE_GEMINI',
|
||||
'CLAUDE_CODE_USE_GITHUB',
|
||||
'CLAUDE_CODE_USE_BEDROCK',
|
||||
'CLAUDE_CODE_USE_VERTEX',
|
||||
'OPENAI_BASE_URL',
|
||||
'OPENAI_API_KEY',
|
||||
'OPENAI_MODEL',
|
||||
'GEMINI_MODEL',
|
||||
]) {
|
||||
if (originalEnv[key] === undefined) delete process.env[key]
|
||||
else process.env[key] = originalEnv[key]
|
||||
}
|
||||
})
|
||||
|
||||
// --- parseProviderFlag ---
|
||||
|
||||
describe('parseProviderFlag', () => {
|
||||
test('returns provider name when --provider flag present', () => {
|
||||
expect(parseProviderFlag(['--provider', 'openai'])).toBe('openai')
|
||||
})
|
||||
|
||||
test('returns provider name with --model alongside', () => {
|
||||
expect(parseProviderFlag(['--provider', 'gemini', '--model', 'gemini-2.0-flash'])).toBe('gemini')
|
||||
})
|
||||
|
||||
test('returns null when --provider flag absent', () => {
|
||||
expect(parseProviderFlag(['--model', 'gpt-4o'])).toBeNull()
|
||||
})
|
||||
|
||||
test('returns null for empty args', () => {
|
||||
expect(parseProviderFlag([])).toBeNull()
|
||||
})
|
||||
|
||||
test('returns null when --provider has no value', () => {
|
||||
expect(parseProviderFlag(['--provider'])).toBeNull()
|
||||
})
|
||||
|
||||
test('returns null when --provider value starts with --', () => {
|
||||
expect(parseProviderFlag(['--provider', '--model'])).toBeNull()
|
||||
})
|
||||
})
|
||||
|
||||
// --- applyProviderFlag ---
|
||||
|
||||
describe('applyProviderFlag - anthropic', () => {
|
||||
test('sets no env vars for anthropic (default)', () => {
|
||||
const result = applyProviderFlag('anthropic', [])
|
||||
expect(result.error).toBeUndefined()
|
||||
expect(process.env.CLAUDE_CODE_USE_OPENAI).toBeUndefined()
|
||||
expect(process.env.CLAUDE_CODE_USE_GEMINI).toBeUndefined()
|
||||
})
|
||||
})
|
||||
|
||||
describe('applyProviderFlag - openai', () => {
|
||||
test('sets CLAUDE_CODE_USE_OPENAI=1', () => {
|
||||
const result = applyProviderFlag('openai', [])
|
||||
expect(result.error).toBeUndefined()
|
||||
expect(process.env.CLAUDE_CODE_USE_OPENAI).toBe('1')
|
||||
})
|
||||
|
||||
test('sets OPENAI_MODEL when --model is provided', () => {
|
||||
applyProviderFlag('openai', ['--model', 'gpt-4o'])
|
||||
expect(process.env.OPENAI_MODEL).toBe('gpt-4o')
|
||||
})
|
||||
})
|
||||
|
||||
describe('applyProviderFlag - gemini', () => {
|
||||
test('sets CLAUDE_CODE_USE_GEMINI=1', () => {
|
||||
const result = applyProviderFlag('gemini', [])
|
||||
expect(result.error).toBeUndefined()
|
||||
expect(process.env.CLAUDE_CODE_USE_GEMINI).toBe('1')
|
||||
})
|
||||
|
||||
test('sets GEMINI_MODEL when --model is provided', () => {
|
||||
applyProviderFlag('gemini', ['--model', 'gemini-2.0-flash'])
|
||||
expect(process.env.GEMINI_MODEL).toBe('gemini-2.0-flash')
|
||||
})
|
||||
})
|
||||
|
||||
describe('applyProviderFlag - github', () => {
|
||||
test('sets CLAUDE_CODE_USE_GITHUB=1', () => {
|
||||
const result = applyProviderFlag('github', [])
|
||||
expect(result.error).toBeUndefined()
|
||||
expect(process.env.CLAUDE_CODE_USE_GITHUB).toBe('1')
|
||||
})
|
||||
})
|
||||
|
||||
describe('applyProviderFlag - bedrock', () => {
|
||||
test('sets CLAUDE_CODE_USE_BEDROCK=1', () => {
|
||||
const result = applyProviderFlag('bedrock', [])
|
||||
expect(result.error).toBeUndefined()
|
||||
expect(process.env.CLAUDE_CODE_USE_BEDROCK).toBe('1')
|
||||
})
|
||||
})
|
||||
|
||||
describe('applyProviderFlag - vertex', () => {
|
||||
test('sets CLAUDE_CODE_USE_VERTEX=1', () => {
|
||||
const result = applyProviderFlag('vertex', [])
|
||||
expect(result.error).toBeUndefined()
|
||||
expect(process.env.CLAUDE_CODE_USE_VERTEX).toBe('1')
|
||||
})
|
||||
})
|
||||
|
||||
describe('applyProviderFlag - ollama', () => {
|
||||
test('sets CLAUDE_CODE_USE_OPENAI=1 with Ollama base URL', () => {
|
||||
const result = applyProviderFlag('ollama', [])
|
||||
expect(result.error).toBeUndefined()
|
||||
expect(process.env.CLAUDE_CODE_USE_OPENAI).toBe('1')
|
||||
expect(process.env.OPENAI_BASE_URL).toBe('http://localhost:11434/v1')
|
||||
expect(process.env.OPENAI_API_KEY).toBe('ollama')
|
||||
})
|
||||
|
||||
test('sets OPENAI_MODEL when --model is provided', () => {
|
||||
applyProviderFlag('ollama', ['--model', 'llama3.2'])
|
||||
expect(process.env.OPENAI_MODEL).toBe('llama3.2')
|
||||
})
|
||||
|
||||
test('does not override existing OPENAI_BASE_URL when user set a custom one', () => {
|
||||
process.env.OPENAI_BASE_URL = 'http://my-ollama:11434/v1'
|
||||
applyProviderFlag('ollama', [])
|
||||
expect(process.env.OPENAI_BASE_URL).toBe('http://my-ollama:11434/v1')
|
||||
})
|
||||
})
|
||||
|
||||
describe('applyProviderFlag - invalid provider', () => {
|
||||
test('returns error for unknown provider', () => {
|
||||
const result = applyProviderFlag('unknown-provider', [])
|
||||
expect(result.error).toContain('unknown-provider')
|
||||
expect(result.error).toContain(VALID_PROVIDERS.join(', '))
|
||||
})
|
||||
})
|
||||
107
src/utils/providerFlag.ts
Normal file
107
src/utils/providerFlag.ts
Normal file
@@ -0,0 +1,107 @@
|
||||
/**
|
||||
* --provider CLI flag support.
|
||||
*
|
||||
* Maps the user-friendly provider name to the environment variables
|
||||
* that the rest of the codebase uses for provider detection.
|
||||
*
|
||||
* Usage:
|
||||
* openclaude --provider openai --model gpt-4o
|
||||
* openclaude --provider gemini --model gemini-2.0-flash
|
||||
* openclaude --provider ollama --model llama3.2
|
||||
* openclaude --provider anthropic (default, no-op)
|
||||
*/
|
||||
|
||||
export const VALID_PROVIDERS = [
|
||||
'anthropic',
|
||||
'openai',
|
||||
'gemini',
|
||||
'github',
|
||||
'bedrock',
|
||||
'vertex',
|
||||
'ollama',
|
||||
] as const
|
||||
|
||||
export type ProviderFlagName = (typeof VALID_PROVIDERS)[number]
|
||||
|
||||
/**
|
||||
* Extract the value of --provider from argv.
|
||||
* Returns null if the flag is absent or has no value.
|
||||
*/
|
||||
export function parseProviderFlag(args: string[]): string | null {
|
||||
const idx = args.indexOf('--provider')
|
||||
if (idx === -1) return null
|
||||
const value = args[idx + 1]
|
||||
if (!value || value.startsWith('--')) return null
|
||||
return value
|
||||
}
|
||||
|
||||
/**
|
||||
* Extract the value of --model from argv.
|
||||
* Returns null if absent.
|
||||
*/
|
||||
function parseModelFlag(args: string[]): string | null {
|
||||
const idx = args.indexOf('--model')
|
||||
if (idx === -1) return null
|
||||
const value = args[idx + 1]
|
||||
if (!value || value.startsWith('--')) return null
|
||||
return value
|
||||
}
|
||||
|
||||
/**
|
||||
* Apply a provider name to process.env.
|
||||
* Sets the required CLAUDE_CODE_USE_* flag and any provider-specific
|
||||
* defaults (Ollama base URL, model routing). Does NOT overwrite values
|
||||
* that are already set — explicit env vars always win.
|
||||
*
|
||||
* Returns { error } if the provider name is not recognized.
|
||||
*/
|
||||
export function applyProviderFlag(
|
||||
provider: string,
|
||||
args: string[],
|
||||
): { error?: string } {
|
||||
if (!(VALID_PROVIDERS as readonly string[]).includes(provider)) {
|
||||
return {
|
||||
error: `Unknown provider "${provider}". Valid providers: ${VALID_PROVIDERS.join(', ')}`,
|
||||
}
|
||||
}
|
||||
|
||||
const model = parseModelFlag(args)
|
||||
|
||||
switch (provider as ProviderFlagName) {
|
||||
case 'anthropic':
|
||||
// Default — no env vars needed
|
||||
break
|
||||
|
||||
case 'openai':
|
||||
process.env.CLAUDE_CODE_USE_OPENAI = '1'
|
||||
if (model) process.env.OPENAI_MODEL ??= model
|
||||
break
|
||||
|
||||
case 'gemini':
|
||||
process.env.CLAUDE_CODE_USE_GEMINI = '1'
|
||||
if (model) process.env.GEMINI_MODEL ??= model
|
||||
break
|
||||
|
||||
case 'github':
|
||||
process.env.CLAUDE_CODE_USE_GITHUB = '1'
|
||||
if (model) process.env.OPENAI_MODEL ??= model
|
||||
break
|
||||
|
||||
case 'bedrock':
|
||||
process.env.CLAUDE_CODE_USE_BEDROCK = '1'
|
||||
break
|
||||
|
||||
case 'vertex':
|
||||
process.env.CLAUDE_CODE_USE_VERTEX = '1'
|
||||
break
|
||||
|
||||
case 'ollama':
|
||||
process.env.CLAUDE_CODE_USE_OPENAI = '1'
|
||||
process.env.OPENAI_BASE_URL ??= 'http://localhost:11434/v1'
|
||||
process.env.OPENAI_API_KEY ??= 'ollama'
|
||||
if (model) process.env.OPENAI_MODEL ??= model
|
||||
break
|
||||
}
|
||||
|
||||
return {}
|
||||
}
|
||||
Reference in New Issue
Block a user