fix(github): address PR feedback for onboarding flow

- Set competing provider flags to undefined in updateSettingsForSource to ensure clean GitHub boot
- Fix resolveProviderRequest to default to github:copilot when OPENAI_MODEL is unset
- Hydrate secure tokens and managed settings in system-check.ts to prevent false negatives
- Add models:read scope to GitHub device flow
This commit is contained in:
Rithul Kamesh
2026-04-02 15:38:54 +05:30
parent f07f11b7b6
commit 0a42839475
4 changed files with 22 additions and 5 deletions

View File

@@ -29,6 +29,11 @@ function mergeUserSettingsEnv(model: string): { ok: boolean; detail?: string } {
env: {
CLAUDE_CODE_USE_GITHUB: '1',
OPENAI_MODEL: model,
CLAUDE_CODE_USE_OPENAI: undefined as any,
CLAUDE_CODE_USE_GEMINI: undefined as any,
CLAUDE_CODE_USE_BEDROCK: undefined as any,
CLAUDE_CODE_USE_VERTEX: undefined as any,
CLAUDE_CODE_USE_FOUNDRY: undefined as any,
},
})
if (error) {
@@ -49,6 +54,7 @@ function OnboardGithub(props: {
verification_uri: string
} | null>(null)
const [patDraft, setPatDraft] = useState('')
const [cursorOffset, setCursorOffset] = useState(0)
const finalize = useCallback(
async (token: string, model: string = DEFAULT_MODEL) => {
@@ -117,7 +123,7 @@ function OnboardGithub(props: {
<Text color="red">{errorMsg}</Text>
<Select
options={options}
onChange={v => {
onChange={(v: string) => {
if (v === 'back') {
setStep('menu')
setErrorMsg(null)
@@ -161,7 +167,7 @@ function OnboardGithub(props: {
value={patDraft}
mask="*"
onChange={setPatDraft}
onSubmit={async value => {
onSubmit={async (value: string) => {
const t = value.trim()
if (!t) {
return
@@ -172,6 +178,9 @@ function OnboardGithub(props: {
setStep('menu')
setPatDraft('')
}}
columns={80}
cursorOffset={cursorOffset}
onChangeCursorOffset={setCursorOffset}
/>
</Box>
)
@@ -202,7 +211,7 @@ function OnboardGithub(props: {
</Text>
<Select
options={menuOptions}
onChange={v => {
onChange={(v: string) => {
if (v === 'cancel') {
onDone('GitHub onboard cancelled', { display: 'system' })
return